Fix dependencyAnalysis plugin #2766
Merged
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the plugin needs to be manually applied to all the libs, otherwise running `./gradlew buildHealth` does nothing.
Also, I had to add it to the convention plugins instead of using the `subprojects { ... }` approach because of the `:libraries:rustsdk` and `:libraries:textcomposer:lib` modules, which aren't proper Java/Kotlin modules.
|
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2766 +/- ##
========================================
Coverage 73.60% 73.60%
========================================
Files 1504 1504
Lines 36058 36058
Branches 6957 6957
========================================
Hits 26539 26539
Misses 5870 5870
Partials 3649 3649 ☔ View full report in Codecov by Sentry. |
jmartinesp
deleted the
misc/jme/make-dependency-analysis-dependency-work-again
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Motivation and context
For some reason the plugin needs to be manually applied to all the libs, otherwise running
./gradlew buildHealthdoes nothing.Also, I had to add it to the convention plugins instead of using the
subprojects { ... }approach because of the:libraries:rustsdkand:libraries:textcomposer:libmodules, which aren't proper Java/Kotlin modules.Tests
./gradlew buildHealthshould take a while now and produce a large.txtreport.Tested devices
Checklist